chrome/renderer/translate/translate_helper_metrics.h - Issue 14762014: Translate: move UMA related code in TranslateManager to TranslateManagerMetrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/translate/translate_helper_metrics.h

Issue 14762014: Translate: move UMA related code in TranslateManager to TranslateManagerMetrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix typos Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_manager_metrics_unittest.cc ('k') | chrome/renderer/translate/translate_helper_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/translate/translate_helper_metrics.h

diff --git a/chrome/renderer/translate/translate_helper_metrics.h b/chrome/renderer/translate/translate_helper_metrics.h

index 43c50fc4d5f9b524e5882e90f31a21ded2eb2e9d..af23d82336cdfe60ca0b7f7ee63b46111031e62b 100644

--- a/chrome/renderer/translate/translate_helper_metrics.h

+++ b/chrome/renderer/translate/translate_helper_metrics.h

@@ -12,8 +12,7 @@

namespace TranslateHelperMetrics {

// An indexing type to query each UMA entry name via GetMetricsName() function.

-// Note: The implementation of GetMetricsName() should be updated when a new

-// entry is added here.

+// Note: |kMetricsEntries| should be updated when a new entry is added here.

enum MetricsNameIndex {

UMA_LANGUAGE_DETECTION,

UMA_CONTENT_LANGUAGE,