Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 14762014: Translate: move UMA related code in TranslateManager to TranslateManagerMetrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typos Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index ff2f2df96fc65b34397a47906755e83c8e82581e..a5b3dbb99a9bf2635adce83d309bcfc4a2fe3931 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -708,7 +708,7 @@ void TranslateManager::RevertTranslation(WebContents* web_contents) {
}
void TranslateManager::ReportLanguageDetectionError(WebContents* web_contents) {
- UMA_HISTOGRAM_COUNTS("Translate.ReportLanguageDetectionError", 1);
+ TranslateManagerMetrics::ReportLanguageDetectionError();
// We'll open the URL in a new tab so that the user can tell us more.
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
if (!browser) {
@@ -766,7 +766,7 @@ void TranslateManager::PageTranslated(WebContents* web_contents,
// TODO(jcivelli): http://crbug.com/9390 We should change the "after
// translate" infobar to support unknown as the original
// language.
- UMA_HISTOGRAM_COUNTS("Translate.ServerReportedUnsupportedLanguage", 1);
+ TranslateManagerMetrics::ReportUnsupportedLanguage();
details->error_type = TranslateErrors::UNSUPPORTED_LANGUAGE;
}
Profile* profile =
« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698