Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: chrome/browser/translate/translate_manager_metrics.h

Issue 14762014: Translate: move UMA related code in TranslateManager to TranslateManagerMetrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_metrics.h
diff --git a/chrome/browser/translate/translate_manager_metrics.h b/chrome/browser/translate/translate_manager_metrics.h
index 011c3c3fe08b8165b877aa2b64925ef844926b35..a09a95eab4416393a0273f1814ab82fde936ae2f 100644
--- a/chrome/browser/translate/translate_manager_metrics.h
+++ b/chrome/browser/translate/translate_manager_metrics.h
@@ -7,8 +7,12 @@
namespace TranslateManagerMetrics {
+// An indexing type to query each UMA entry name via GetMetricsName() function.
+// Note: |kMetricsEntries| should be updated when a new entry is added here.
enum MetricsNameIndex {
UMA_INITIATION_STATUS,
+ UMA_LANGUAGE_DETECTION_ERROR,
+ UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
UMA_MAX,
};
@@ -34,6 +38,12 @@ enum InitiationStatusType {
// browser action.
void ReportInitiationStatus(InitiationStatusType type);
+// Called when Chrome opens the URL so that the user sends an error feedback.
+void ReportLanguageDetectionError();
+
+// Called when it's turned out that translating page is in unsupported language.
MAD 2013/05/15 01:32:48 it's turned -> it turns
Takashi Toyoshima 2013/05/15 07:35:04 thanks!
+void ReportUnsupportedLanguage();
+
// Provides UMA entry names for unit tests.
const char* GetMetricsName(MetricsNameIndex index);

Powered by Google App Engine
This is Rietveld 408576698