Translate: move UMA related code in TranslateManager to TranslateManagerMetrics

chrome/renderer/translate/translate_helper_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/translate/translate_helper_metrics.h"
 
+#include "base/basictypes.h"
 #include "base/metrics/histogram.h"
 
 namespace {
 
-// Constant string values to indicate UMA names. All entry should have
+// Constant string values to indicate UMA names. All entries should have
 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
 const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection";
 const char kTranslateContentLanguage[] = "Translate.ContentLanguage";
 const char kTranslateLanguageVerification[] = "Translate.LanguageVerification";
 const char kTranslateTimeToBeReady[] = "Translate.TimeToBeReady";
 const char kTranslateTimeToLoad[] = "Translate.TimeToLoad";
 const char kTranslateTimeToTranslate[] = "Translate.TimeToTranslate";
 
 struct MetricsEntry {
   TranslateHelperMetrics::MetricsNameIndex index;
   const char* const name;
 };
 
-// This entry table should be updated when new UMA item is added.
+// This entry table should be updated when new UMA items are added.
 const MetricsEntry kMetricsEntries[] = {
   { TranslateHelperMetrics::UMA_LANGUAGE_DETECTION,
     kRenderer4LanguageDetection },
   { TranslateHelperMetrics::UMA_CONTENT_LANGUAGE,
     kTranslateContentLanguage },
   { TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION,
     kTranslateLanguageVerification },
   { TranslateHelperMetrics::UMA_TIME_TO_BE_READY,
     kTranslateTimeToBeReady },
   { TranslateHelperMetrics::UMA_TIME_TO_LOAD,
     kTranslateTimeToLoad },
   { TranslateHelperMetrics::UMA_TIME_TO_TRANSLATE,
     kTranslateTimeToTranslate },
 };
 
+COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateHelperMetrics::UMA_MAX,
+               arraysize_of_kMetricsEntries_should_be_UMA_MAX);
+
 }  // namespace
 
 namespace TranslateHelperMetrics {
 
 void ReportContentLanguage(const std::string& provided_code,
                            const std::string& revised_code) {
   if (provided_code.empty()) {
     UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage,
                               CONTENT_LANGUAGE_NOT_PROVIDED,
                               CONTENT_LANGUAGE_MAX);
@@ skipping 43 matching lines @@
 const char* GetMetricsName(MetricsNameIndex index) {
   for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
     if (kMetricsEntries[i].index == index)
       return kMetricsEntries[i].name;
   }
   NOTREACHED();
   return NULL;
 }
 
 } // namespace TranslateHelperMetrics