Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/renderer/translate/translate_helper_metrics.cc

Issue 14762014: Translate: move UMA related code in TranslateManager to TranslateManagerMetrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/translate/translate_helper_metrics.h" 5 #include "chrome/renderer/translate/translate_helper_metrics.h"
6 6
7 #include "base/basictypes.h"
7 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
8 9
9 namespace { 10 namespace {
10 11
11 // Constant string values to indicate UMA names. All entry should have 12 // Constant string values to indicate UMA names. All entry should have
12 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|. 13 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
13 const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection"; 14 const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection";
14 const char kTranslateContentLanguage[] = "Translate.ContentLanguage"; 15 const char kTranslateContentLanguage[] = "Translate.ContentLanguage";
15 const char kTranslateLanguageVerification[] = "Translate.LanguageVerification"; 16 const char kTranslateLanguageVerification[] = "Translate.LanguageVerification";
16 const char kTranslateTimeToBeReady[] = "Translate.TimeToBeReady"; 17 const char kTranslateTimeToBeReady[] = "Translate.TimeToBeReady";
(...skipping 14 matching lines...) Expand all
31 { TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION, 32 { TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION,
32 kTranslateLanguageVerification }, 33 kTranslateLanguageVerification },
33 { TranslateHelperMetrics::UMA_TIME_TO_BE_READY, 34 { TranslateHelperMetrics::UMA_TIME_TO_BE_READY,
34 kTranslateTimeToBeReady }, 35 kTranslateTimeToBeReady },
35 { TranslateHelperMetrics::UMA_TIME_TO_LOAD, 36 { TranslateHelperMetrics::UMA_TIME_TO_LOAD,
36 kTranslateTimeToLoad }, 37 kTranslateTimeToLoad },
37 { TranslateHelperMetrics::UMA_TIME_TO_TRANSLATE, 38 { TranslateHelperMetrics::UMA_TIME_TO_TRANSLATE,
38 kTranslateTimeToTranslate }, 39 kTranslateTimeToTranslate },
39 }; 40 };
40 41
42 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateHelperMetrics::UMA_MAX,
43 arraysize_of_kMetricsEntries_should_be_UMA_MAX);
44
41 } // namespace 45 } // namespace
42 46
43 namespace TranslateHelperMetrics { 47 namespace TranslateHelperMetrics {
44 48
45 void ReportContentLanguage(const std::string& provided_code, 49 void ReportContentLanguage(const std::string& provided_code,
46 const std::string& revised_code) { 50 const std::string& revised_code) {
47 if (provided_code.empty()) { 51 if (provided_code.empty()) {
48 UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage, 52 UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage,
49 CONTENT_LANGUAGE_NOT_PROVIDED, 53 CONTENT_LANGUAGE_NOT_PROVIDED,
50 CONTENT_LANGUAGE_MAX); 54 CONTENT_LANGUAGE_MAX);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 const char* GetMetricsName(MetricsNameIndex index) { 98 const char* GetMetricsName(MetricsNameIndex index) {
95 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) { 99 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
96 if (kMetricsEntries[i].index == index) 100 if (kMetricsEntries[i].index == index)
97 return kMetricsEntries[i].name; 101 return kMetricsEntries[i].name;
98 } 102 }
99 NOTREACHED(); 103 NOTREACHED();
100 return NULL; 104 return NULL;
101 } 105 }
102 106
103 } // namespace TranslateHelperMetrics 107 } // namespace TranslateHelperMetrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698