tests/gclient_utils_test.py - Issue 14759006: Kill subprocesses on KeyboardInterrupt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_utils_test.py

Issue 14759006: Kill subprocesses on KeyboardInterrupt. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Don't pop from a list as it's being iterated. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_utils_test.py

diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py

index 2703e5d955832e9201f5167e7d16ddd86c14e814..4976d9a7b492b676c7de9999b80504f35f2e6abf 100755

--- a/tests/gclient_utils_test.py

+++ b/tests/gclient_utils_test.py

@@ -34,7 +34,8 @@ class GclientUtilsUnittest(GclientUtilBase):

'GetGClientRootAndEntries', 'GetEditor', 'IsDateRevision',

'MakeDateRevision', 'MakeFileAutoFlush', 'MakeFileAnnotated',

'PathDifference', 'ParseCodereviewSettingsContent', 'NumLocalCpus',

- 'PrintableObject', 'RunEditor',

+ 'PrintableObject', 'RunEditor', 'GCLIENT_CHILDREN',

+ 'GCLIENT_CHILDREN_LOCK', 'GClientChildren',

'SplitUrlRevision', 'SyntaxErrorToError', 'UpgradeToHttps', 'Wrapper',

'WorkItem', 'codecs', 'lockedmethod', 'logging', 'os', 'Queue', 're',

'rmtree', 'safe_makedirs', 'stat', 'subprocess', 'subprocess2', 'sys',

@@ -49,6 +50,7 @@ class CheckCallAndFilterTestCase(GclientUtilBase):

class ProcessIdMock(object):

def __init__(self, test_string):

self.stdout = StringIO.StringIO(test_string)

+ self.pid = 9284

def wait(self):

pass

« gclient_utils.py ('K') | « gclient_utils.py ('k') | no next file » | no next file with comments »