gclient.py - Issue 14759006: Kill subprocesses on KeyboardInterrupt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 14759006: Kill subprocesses on KeyboardInterrupt. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Don't pop from a list as it's being iterated. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index 90b75d9a2d64604c6cd4ec4f00e6ec5920e75c10..242cf0f2f7b6e0abddf9ad39504e6ce7584c89ae 100755

--- a/gclient.py

+++ b/gclient.py

@@ -1777,6 +1777,9 @@ def Main(argv):

# Not a known command. Default to help.

GenUsage(parser, 'help')

return CMDhelp(parser, argv)

+ except KeyboardInterrupt:

+ gclient_utils.GClientChildren.KillAllRemainingChildren()

+ raise

except (gclient_utils.Error, subprocess2.CalledProcessError), e:

print >> sys.stderr, 'Error: %s' % str(e)

return 1

« no previous file with comments | « no previous file | gclient_utils.py » ('j') | gclient_utils.py » ('J')