Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 14758009: Revert "Web MIDI: implement MIDIOutput" (Closed)

Created:
7 years, 7 months ago by danakj
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Revert "Web MIDI: implement MIDIOutput" This reverts commit 3559701d6e127ef5fcb92a5fe43caa8e71fb11f6. Breaks webexposed/global-constructors-listing.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&showExpectations=true&tests=webexposed%2Fglobal-constructors-listing.html NOTRY=true TBR=toyoshim@chromium.org > Web MIDI: implement MIDIOutput > > This change implements MIDIOutput interfaces. > send methods are not implemeneted yet. > > BUG=163795 > TEST=none > NOTRY=true > R=crogers@google.com,haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149649 > > Review URL: https://chromiumcodereview.appspot.com/14442004 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -151 lines) Patch
M Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D Source/modules/webmidi/MIDIOutput.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/modules/webmidi/MIDIOutput.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/modules/webmidi/MIDIOutput.idl View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
No reviewers yet.
7 years, 7 months ago (2013-05-13 16:07:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/14758009/1
7 years, 7 months ago (2013-05-13 16:08:43 UTC) #2
commit-bot: I haz the power
Change committed as 150226
7 years, 7 months ago (2013-05-13 16:08:54 UTC) #3
eseidel
The CQ was used to land the original patch, yet it landed it including the ...
7 years, 7 months ago (2013-05-13 17:29:18 UTC) #4
danakj
On 2013/05/13 17:29:18, Eric Seidel wrote: > The CQ was used to land the original ...
7 years, 7 months ago (2013-05-13 17:31:04 UTC) #5
danakj
7 years, 7 months ago (2013-05-13 17:32:06 UTC) #6
Message was sent while issue was closed.
On 2013/05/13 17:31:04, danakj wrote:
> On 2013/05/13 17:29:18, Eric Seidel wrote:
> > The CQ was used to land the original patch, yet it landed it including the
> > failure.  Lame.
> 
> Indeed. Filing bug.

Here: https://code.google.com/p/chromium/issues/detail?id=240326

Powered by Google App Engine
This is Rietveld 408576698