Issue 14753003: Don't open mobile setup when activating Sprint network from network menu

Issue 14753003: Don't open mobile setup when activating Sprint network from network menu (Closed)

Created:
7 years, 7 months ago by tbarzic

Modified:
7 years, 7 months ago

Reviewers:
rkc, stevenjb, Ben Chan

CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't open mobile setup when activating Sprint network from network menu it should be activated directly BUG=chrome-os-partner:16215 TEST=tbd Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201159

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : add mock #

Patch Set 7 : rebase #

Patch Set 8 : . #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -14 lines)			Patch
M	chrome/browser/chromeos/cros/mock_network_library.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library_impl_base.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library_impl_base.cc	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	1 2 3 4 5 6	1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View	1 2 3 4 5 6 7	3 chunks	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

tbarzic

please take a look https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode916 chrome/browser/chromeos/cros/network_library.cc:916: return operator_name_ == shill::kCarrierSprint; this ...

7 years, 7 months ago (2013-05-02 01:07:29 UTC) #1

stevenjb

Code lgtm, assuming you can verify your assumption. https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode916 chrome/browser/chromeos/cros/network_library.cc:916: return ...

7 years, 7 months ago (2013-05-03 22:19:34 UTC) #2

tbarzic

https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode915 chrome/browser/chromeos/cros/network_library.cc:915: bool CellularNetwork::UsesDirectActivation() const { Ben, is this correct way ...

7 years, 7 months ago (2013-05-06 18:02:11 UTC) #3

Ben Chan

https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): https://codereview.chromium.org/14753003/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode916 chrome/browser/chromeos/cros/network_library.cc:916: return operator_name_ == shill::kCarrierSprint; Should be checked against Device.Carrier ...

7 years, 7 months ago (2013-05-06 18:07:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/14753003/35001

7 years, 7 months ago (2013-05-20 20:07:27 UTC) #7

Message was sent while issue was closed.

Change committed as 201159

Expand Messages | Collapse Messages