Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 14752019: Refer to blink in the safely-roll-blink script. (Closed)

Created:
7 years, 7 months ago by danakj
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Refer to blink in the safely-roll-blink script. Still some old references to webkit that should be changed (unlike the references to "webkit_revision" which is actually what the DEPS files says). NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199243

Patch Set 1 #

Total comments: 2

Patch Set 2 : Caps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/safely-roll-blink.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
7 years, 7 months ago (2013-05-09 17:39:31 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/14752019/diff/1/tools/safely-roll-blink.py File tools/safely-roll-blink.py (right): https://codereview.chromium.org/14752019/diff/1/tools/safely-roll-blink.py#newcode6 tools/safely-roll-blink.py:6: """Generate a CL to roll blink to the ...
7 years, 7 months ago (2013-05-09 17:40:41 UTC) #2
danakj
https://codereview.chromium.org/14752019/diff/1/tools/safely-roll-blink.py File tools/safely-roll-blink.py (right): https://codereview.chromium.org/14752019/diff/1/tools/safely-roll-blink.py#newcode6 tools/safely-roll-blink.py:6: """Generate a CL to roll blink to the specified ...
7 years, 7 months ago (2013-05-09 17:42:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/14752019/3002
7 years, 7 months ago (2013-05-09 17:42:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=51144
7 years, 7 months ago (2013-05-09 18:00:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/14752019/3002
7 years, 7 months ago (2013-05-09 18:01:17 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 18:01:33 UTC) #7
Message was sent while issue was closed.
Change committed as 199243

Powered by Google App Engine
This is Rietveld 408576698