Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ui/views/bubble/bubble_border.cc

Issue 14742002: Render opaque border with no shadow for web contents modal dialogs under Views/Win32 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ChromeOS build failure Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/bubble/bubble_border.h ('k') | ui/views/bubble/bubble_frame_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_border.cc
diff --git a/ui/views/bubble/bubble_border.cc b/ui/views/bubble/bubble_border.cc
index 1b6ceed7c5e1a55c3cba8e08f48e835f5da9d1a7..37a8eb1546696758592c88b8b332e3db8c4318da 100644
--- a/ui/views/bubble/bubble_border.cc
+++ b/ui/views/bubble/bubble_border.cc
@@ -112,6 +112,7 @@ BorderImages* GetBorderImages(BubbleBorder::Shadow shadow) {
set = new BorderImages(kShadowImages, kShadowArrows, 0, 0, 3);
break;
case BubbleBorder::NO_SHADOW:
+ case BubbleBorder::NO_SHADOW_OPAQUE_BORDER:
set = new BorderImages(kNoShadowImages, kNoShadowArrows, 6, 7, 4);
break;
case BubbleBorder::BIG_SHADOW:
@@ -332,6 +333,9 @@ void BubbleBorder::DrawArrow(gfx::Canvas* canvas,
}
void BubbleBackground::Paint(gfx::Canvas* canvas, views::View* view) const {
+ if (border_->shadow() == BubbleBorder::NO_SHADOW_OPAQUE_BORDER)
+ canvas->DrawColor(border_->background_color());
+
// Clip out the client bounds to prevent overlapping transparent widgets.
if (!border_->client_bounds().IsEmpty()) {
SkRect client_rect(gfx::RectToSkRect(border_->client_bounds()));
« no previous file with comments | « ui/views/bubble/bubble_border.h ('k') | ui/views/bubble/bubble_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698