net/cert/x509_certificate_nss.cc - Issue 14741019: Disallow wildcards from matching top-level registry controlled domains during cert validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_nss.cc

Issue 14741019: Disallow wildcards from matching top-level registry controlled domains during cert validation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/x509_certificate_nss.cc

diff --git a/net/cert/x509_certificate_nss.cc b/net/cert/x509_certificate_nss.cc

index f6fdd94ab6b88807016b6d798ae0a57928424137..ea2c3505d0a10e0607cbd03e5bcbc9ba50de13da 100644

--- a/net/cert/x509_certificate_nss.cc

+++ b/net/cert/x509_certificate_nss.cc

@@ -152,10 +152,6 @@ void X509Certificate::GetSubjectAltName(

x509_util::GetSubjectAltName(cert_handle_, dns_names, ip_addrs);

}

-bool X509Certificate::VerifyNameMatch(const std::string& hostname) const {

- return CERT_VerifyCertName(cert_handle_, hostname.c_str()) == SECSuccess;

bool X509Certificate::IsIssuedByEncoded(

const std::vector<std::string>& valid_issuers) {

// Get certificate chain as scoped list of CERTCertificate objects.

« no previous file with comments | « net/cert/x509_certificate.cc ('k') | net/cert/x509_certificate_unittest.cc » ('j') | no next file with comments »