Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 14741011: Error event was fired synchronously blowing away the input element from underneath. Remove the FIXM… (Closed)

Created:
7 years, 7 months ago by inferno
Modified:
7 years, 7 months ago
Reviewers:
Nate Chapin, eseidel
CC:
blink-reviews, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Error event was fired synchronously blowing away the input element from underneath. Remove the FIXME and fire it asynchronously using errorEventSender(). BUG=240124 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
A + LayoutTests/fast/forms/image/image-error-event-crash.html View 1 chunk +5 lines, -7 lines 0 comments Download
A + LayoutTests/fast/forms/image/image-error-event-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
inferno
Nate, can you please help to review this. This line was added in http://trac.webkit.org/changeset/94213, do ...
7 years, 7 months ago (2013-05-13 16:33:39 UTC) #1
Nate Chapin
lgtm
7 years, 7 months ago (2013-05-13 16:34:22 UTC) #2
inferno
On 2013/05/13 16:33:39, inferno wrote: > Nate, can you please help to review this. This ...
7 years, 7 months ago (2013-05-13 16:34:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/inferno@chromium.org/14741011/1
7 years, 7 months ago (2013-05-13 16:48:32 UTC) #4
commit-bot: I haz the power
Change committed as 150232
7 years, 7 months ago (2013-05-13 17:29:56 UTC) #5
eseidel
GOM thinks this checkin is missing results on LION.
7 years, 7 months ago (2013-05-13 18:20:23 UTC) #6
aarya
On 2013/05/13 18:20:23, Eric Seidel wrote: > GOM thinks this checkin is missing results on ...
7 years, 7 months ago (2013-05-13 18:24:52 UTC) #7
hshi1
7 years, 7 months ago (2013-05-14 19:14:56 UTC) #8
Message was sent while issue was closed.
On 2013/05/13 18:24:52, aarya wrote:
> On 2013/05/13 18:20:23, Eric Seidel wrote:
> > GOM thinks this checkin is missing results on LION.
> 
> Link to errors ?

This checkin is causing image loading failures on Chrome OS file manager.
https://code.google.com/p/chromium/issues/detail?id=240751

Powered by Google App Engine
This is Rietveld 408576698