Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: Source/WebKit/chromium/src/WebAccessibilityObject.cpp

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Re-landing with null check fix Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/accessibility/AccessibilityListBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/WebAccessibilityObject.cpp
diff --git a/Source/WebKit/chromium/src/WebAccessibilityObject.cpp b/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
index e9882643d4c2377e64c1b2634df34aa2b5ffbcc6..fca39c97268fc4c440753f85f9682df7cc562ea1 100644
--- a/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
+++ b/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
@@ -491,7 +491,7 @@ WebRect WebAccessibilityObject::boundingBoxRect() const
if (isDetached())
return WebRect();
- return m_private->pixelSnappedBoundingBoxRect();
+ return pixelSnappedIntRect(m_private->elementRect());
}
bool WebAccessibilityObject::canvasHasFallbackContent() const
@@ -561,7 +561,7 @@ WebAccessibilityObject WebAccessibilityObject::hitTest(const WebPoint& point) co
if (hit)
return WebAccessibilityObject(hit);
- if (m_private->boundingBoxRect().contains(contentsPoint))
+ if (m_private->elementRect().contains(contentsPoint))
return *this;
return WebAccessibilityObject();
« no previous file with comments | « no previous file | Source/core/accessibility/AccessibilityListBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698