Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 14740022: Enable clang and host_os when generating ninja-ios. (Closed)

Created:
7 years, 7 months ago by Justin Cohen (wrong one)
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable clang and host_os when generating ninja-ios. Default clang=1 and host_os==mac when GENERATOR==ninja and OS==ios. BUG=236517 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199171

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Set host_os too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
justincohen
Not sure who the right reviewer is for this. PTAL?
7 years, 7 months ago (2013-05-07 19:16:06 UTC) #1
Nico
lgtm
7 years, 7 months ago (2013-05-08 22:23:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/14740022/3001
7 years, 7 months ago (2013-05-08 22:33:26 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 09:20:03 UTC) #4
Message was sent while issue was closed.
Change committed as 199171

Powered by Google App Engine
This is Rietveld 408576698