Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 1473963004: CSS animation for SVG presentation attribute 'd' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Oilpan Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index 23fa5ca7da0013a737e24f4e4bb8ed8055f6f60d..67cc56ae60531709c5cf68e5572fa4abd9655168 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -44,6 +44,7 @@
#include "core/animation/animatable/AnimatableLengthPoint.h"
#include "core/animation/animatable/AnimatableLengthPoint3D.h"
#include "core/animation/animatable/AnimatableLengthSize.h"
+#include "core/animation/animatable/AnimatablePath.h"
#include "core/animation/animatable/AnimatableRepeatable.h"
#include "core/animation/animatable/AnimatableSVGPaint.h"
#include "core/animation/animatable/AnimatableShadow.h"
@@ -247,6 +248,11 @@ inline static PassRefPtr<AnimatableValue> createFromShapeValue(ShapeValue* value
return AnimatableUnknown::create(CSSValueNone);
}
+static PassRefPtr<AnimatableValue> createFromPath(CSSPathValue* pathValue)
+{
+ return AnimatablePath::create(pathValue);
+}
+
static double fontStretchToDouble(FontStretch fontStretch)
{
return static_cast<unsigned>(fontStretch);
@@ -573,6 +579,8 @@ PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(CSSPropertyID prop
return AnimatableUnknown::create(CSSPrimitiveValue::create(style.verticalAlign()));
case CSSPropertyVisibility:
return AnimatableVisibility::create(style.visibility());
+ case CSSPropertyD:
+ return createFromPath(style.svgStyle().d());
case CSSPropertyCx:
return createFromLength(style.svgStyle().cx(), style);
case CSSPropertyCy:

Powered by Google App Engine
This is Rietveld 408576698