Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147353007: DevTools: remove references to modules/webdatabase from core/inspector (Closed)

Created:
6 years, 10 months ago by Vladislav Kaznacheev
Modified:
6 years, 10 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

DevTools: remove references to modules/webdatabase from core BUG=340221 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166839

Patch Set 1 : Work in progress #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Addressed comments #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -580 lines) Patch
M Source/core/core.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 2 3 4 5 4 chunks +8 lines, -3 lines 0 comments Download
D Source/core/inspector/InspectorDatabaseAgent.h View 1 1 chunk +0 lines, -85 lines 0 comments Download
D Source/core/inspector/InspectorDatabaseAgent.cpp View 1 1 chunk +0 lines, -329 lines 0 comments Download
D Source/core/inspector/InspectorDatabaseInstrumentation.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/inspector/InspectorDatabaseResource.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/inspector/InspectorDatabaseResource.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseClient.h View 1 2 3 1 chunk +10 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseClient.cpp View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
A + Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 1 chunk +0 lines, -1 line 0 comments Download
A + Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 2 chunks +4 lines, -11 lines 0 comments Download
A + Source/modules/webdatabase/InspectorDatabaseResource.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webdatabase/InspectorDatabaseResource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Vladislav Kaznacheev
6 years, 10 months ago (2014-02-05 08:34:41 UTC) #1
pfeldman
https://codereview.chromium.org/147353007/diff/70001/Source/core/inspector/InspectorController.cpp File Source/core/inspector/InspectorController.cpp (right): https://codereview.chromium.org/147353007/diff/70001/Source/core/inspector/InspectorController.cpp#newcode424 Source/core/inspector/InspectorController.cpp:424: for (size_t i = 0; i < m_moduleAgents.size(); i++) ...
6 years, 10 months ago (2014-02-05 13:21:43 UTC) #2
Vladislav Kaznacheev
PTAL https://chromiumcodereview.appspot.com/147353007/diff/70001/Source/core/inspector/InspectorController.cpp File Source/core/inspector/InspectorController.cpp (right): https://chromiumcodereview.appspot.com/147353007/diff/70001/Source/core/inspector/InspectorController.cpp#newcode424 Source/core/inspector/InspectorController.cpp:424: for (size_t i = 0; i < m_moduleAgents.size(); ...
6 years, 10 months ago (2014-02-06 12:38:35 UTC) #3
pfeldman
lgtm
6 years, 10 months ago (2014-02-06 14:04:10 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-10 14:03:27 UTC) #5
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 10 months ago (2014-02-10 14:07:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/147353007/280001
6 years, 10 months ago (2014-02-10 14:07:48 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 16:14:01 UTC) #8
Message was sent while issue was closed. 
Change committed as 166839

Powered by Google App Engine
This is Rietveld 408576698