Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 14735007: RefPtr several Frame* iterations (Closed)

Created:
7 years, 7 months ago by Cris Neckar
Modified:
7 years, 7 months ago
Reviewers:
Nate Chapin, inferno
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

RefPtr several Frame* iterations BUG=178264 TEST=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/page/Frame.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Cris Neckar
can you guys re-review https://codereview.chromium.org/14702005/ here. THat issue is broken beyond fixing. Thanks
7 years, 7 months ago (2013-05-07 18:33:31 UTC) #1
inferno
lgtm
7 years, 7 months ago (2013-05-07 18:42:10 UTC) #2
Nate Chapin
lgtm
7 years, 7 months ago (2013-05-07 18:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/14735007/1
7 years, 7 months ago (2013-05-07 19:02:43 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=4266
7 years, 7 months ago (2013-05-07 20:32:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/14735007/1
7 years, 7 months ago (2013-05-07 20:33:42 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=4284
7 years, 7 months ago (2013-05-07 22:02:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/14735007/1
7 years, 7 months ago (2013-05-07 22:05:24 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 22:45:15 UTC) #9
Message was sent while issue was closed.
Change committed as 149904

Powered by Google App Engine
This is Rietveld 408576698