Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 14734009: More Compiler.h cleanups. (Closed)

Created:
7 years, 7 months ago by Nico
Modified:
7 years, 7 months ago
Reviewers:
pdr., abarth-chromium
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

More Compiler.h cleanups. * We support neither gcce nor icc. * Our gcc is always newer than 3.0.3. * Our clang always has __has_extension * UNUSED_LABEL isn't used anywhere BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150429

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -46 lines) Patch
M Source/wtf/Alignment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Assertions.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M Source/wtf/Compiler.h View 3 chunks +0 lines, -16 lines 0 comments Download
M Source/wtf/UnusedParam.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
7 years, 7 months ago (2013-05-15 02:41:11 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-15 02:43:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14734009/1005
7 years, 7 months ago (2013-05-15 02:44:29 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/wtf/Assertions.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-15 02:44:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14734009/6001
7 years, 7 months ago (2013-05-15 05:45:37 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 14:38:38 UTC) #6
Message was sent while issue was closed.
Change committed as 150429

Powered by Google App Engine
This is Rietveld 408576698