Issue 14732009: Make NavigationScheduler correctly track user gestures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14732009: Make NavigationScheduler correctly track user gestures. (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 7 months ago

Reviewers:
Nate Chapin

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make NavigationScheduler correctly track user gestures. If a navigation is scheduled while a user gesture is active, store a token for the gesture and use it to reinstantiate the UserGestureIndicator instead of creating a new one all the time Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149759

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -8 lines)			Patch
A	LayoutTests/fast/loader/navigation-scheduler-user-gesture.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/loader/navigation-scheduler-user-gesture-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/loader/NavigationScheduler.cpp	View	10 chunks	+17 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14732009/1

7 years, 7 months ago (2013-05-06 18:16:02 UTC) #2

Message was sent while issue was closed.

Change committed as 149759

Expand Messages | Collapse Messages