Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 14731016: Always use BuildCheckNonSmi, and don't emit check if HeapObject. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Always use BuildCheckNonSmi, and don't emit check if HeapObject. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M src/hydrogen.cc View 14 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-10 08:57:04 UTC) #1
mvstanton
lgtm
7 years, 7 months ago (2013-05-10 08:58:46 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-10 08:59:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698