Add option to prevent gclient from changing remote

Add option to prevent gclient from changing remote

Allow users to set a git config entry which stops
gclient from messing with remote.origin.url. Useful
for using experimental repos.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=199532

[M-A Ruel, 2013-05-10 13:59:07]

Why not use 'custom_deps': { 'src/third_party/WebKit': None }  ?

[Isaac (away), 2013-05-10 17:40:19]

A couple reasons:

1) Since refs/heads/* folders are the same, this makes gclient treat the
experimental folder the same as if it were the official repo, doing the same
syncing behavior as before.

2) This will also be used for
https://chromium.googlesource.com/experimental/chromium/src/

WDYT?

[M-A Ruel, 2013-05-10 19:58:36]

On 2013/05/10 17:40:19, Isaac wrote:
> A couple reasons:
> 
> 1) Since refs/heads/* folders are the same, this makes gclient treat the
> experimental folder the same as if it were the official repo, doing the same
> syncing behavior as before.
> 
> 2) This will also be used for
> https://chromium.googlesource.com/experimental/chromium/src/
> 
> WDYT?

I still think this is wrong and the setup is improperly done but lgtm.

[commit-bot: I haz the power, 2013-05-10 20:50:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/14731015/1

[commit-bot: I haz the power, 2013-05-10 20:52:15]

Change committed as 199532

[Isaac (away), 2013-05-10 21:04:07]

Thanks M-A.  I realize this workflow isn't normal.  At some point we'll allow
pushes to the official git repos in refs/wip, so this is a temporary solution
that mimics the planned future workflow.

I appreciate the review.

[M-A Ruel, 2013-05-11 12:15:06]

On 2013/05/10 21:04:07, Isaac wrote:
> Thanks M-A.  I realize this workflow isn't normal.  At some point we'll allow
> pushes to the official git repos in refs/wip, so this is a temporary solution
> that mimics the planned future workflow.
> 
> I appreciate the review.

For the record, if the name was more self-descriptive, like
remote.gclient.autofix_url = False, I'd be much less concerned. In particular,
gclient only touches origin so using remote.origin.gclient is not necessary.

[Marc-Antoine Ruel (Google), 2013-05-11 16:15:26]

oops, I meant remote.origin.client.auto_fix_url.
Le 11 mai 2013 08:15, <maruel@chromium.org> a écrit :

> On 2013/05/10 21:04:07, Isaac wrote:
>
>> Thanks M-A.  I realize this workflow isn't normal.  At some point we'll
>> allow
>> pushes to the official git repos in refs/wip, so this is a temporary
>> solution
>> that mimics the planned future workflow.
>>
>
>  I appreciate the review.
>>
>
> For the record, if the name was more self-descriptive, like
> remote.gclient.autofix_url = False, I'd be much less concerned. In
> particular,
> gclient only touches origin so using remote.origin.gclient is not
> necessary.
>
>
https://chromiumcodereview.**appspot.com/14731015/<https://chromiumcodereview...
>

[szym, 2013-05-22 00:01:48]

https://chromiumcodereview.appspot.com/14731015/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://chromiumcodereview.appspot.com/14731015/diff/1/gclient_scm.py#newcode322
gclient_scm.py:322: self._Capture(['config', 'remote.origin.gclient']) !=
'getoffmylawn'):
If the url is different and remote.origin.gclient is not set, gclient fails
with:

Error: Command git config remote.origin.gclient returned non-zero exit status 1
in XXXX/src/third_party/WebKit

[Isaac (away), 2013-05-22 00:13:48]

Thanks, yes it is currently broken.  A fix is landing shortly in
crrev.com/15325003.