Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 14731011: Return caret bounds in local coordinates from GetCaretBoundsInWidget (Closed)

Created:
7 years, 7 months ago by Yohei Yukawa
Modified:
7 years, 7 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Return caret bounds in local coordinates from GetCaretBoundsInWidget This is another regression caused by r197858. There remains another call site of TextInputClient::GetCaretBounds, which now returns the caret rect as screen coordinate as documented in the header. BUG=239737 TEST=Manually done on Windows 7 with built-in Chinese IME. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/views/ime/input_method_base.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Yohei Yukawa
7 years, 7 months ago (2013-05-10 06:43:57 UTC) #1
Seigo Nonaka
lgtm
7 years, 7 months ago (2013-05-10 17:47:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14731011/1
7 years, 7 months ago (2013-05-10 21:16:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=39088
7 years, 7 months ago (2013-05-11 05:23:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14731011/1
7 years, 7 months ago (2013-05-12 05:12:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=126771
7 years, 7 months ago (2013-05-12 09:53:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14731011/1
7 years, 7 months ago (2013-05-12 12:00:18 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=147377
7 years, 7 months ago (2013-05-12 16:17:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14731011/1
7 years, 7 months ago (2013-05-13 02:32:31 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 06:04:29 UTC) #10
Message was sent while issue was closed.
Change committed as 199665

Powered by Google App Engine
This is Rietveld 408576698