Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14730002: Remove features code from ExtensionAPI (Closed)

Created:
7 years, 7 months ago by cduvall
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove features code from ExtensionAPI ExtensionAPI now does not deal with features specified within API schemas. All features should be specified in the _*_features.json files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197640

Patch Set 1 #

Patch Set 2 : add CHECK back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -71 lines) Patch
M chrome/common/extensions/api/extension_api.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 3 chunks +2 lines, -64 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cduvall
7 years, 7 months ago (2013-05-01 00:17:20 UTC) #1
not at google - send to devlin
This is awesome! But you should submit the CHECK and the removal of the features ...
7 years, 7 months ago (2013-05-01 00:19:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/14730002/4001
7 years, 7 months ago (2013-05-01 00:25:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=108913
7 years, 7 months ago (2013-05-01 02:18:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/14730002/4001
7 years, 7 months ago (2013-05-01 02:19:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=35246
7 years, 7 months ago (2013-05-01 05:48:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/14730002/4001
7 years, 7 months ago (2013-05-01 05:58:04 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=35337
7 years, 7 months ago (2013-05-01 08:43:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/14730002/4001
7 years, 7 months ago (2013-05-01 15:31:46 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 16:57:05 UTC) #10
Message was sent while issue was closed. 
Change committed as 197640

Powered by Google App Engine
This is Rietveld 408576698