media/base/android/media_decoder_job.cc - Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_decoder_job.cc

Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_util.h ('K') | « media/base/android/media_codec_video_decoder.cc ('k') | media/base/android/media_jni_registrar.cc » ('j') | media/base/android/ndk_media_codec_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_decoder_job.cc

diff --git a/media/base/android/media_decoder_job.cc b/media/base/android/media_decoder_job.cc

index 3bf5279db91961396a7a1c3f2792af3d4cb2d416..0398582bb2ef6f19736dbaac296135ce47b07944 100644

--- a/media/base/android/media_decoder_job.cc

+++ b/media/base/android/media_decoder_job.cc

@@ -286,9 +286,7 @@ MediaCodecStatus MediaDecoderJob::QueueInputBuffer(const AccessUnit& unit) {

MediaCodecStatus status = media_codec_bridge_->QueueSecureInputBuffer(

input_buf_index,

- &unit.data[0], unit.data.size(),

- reinterpret_cast<const uint8*>(&unit.key_id[0]), unit.key_id.size(),

- reinterpret_cast<const uint8*>(&unit.iv[0]), unit.iv.size(),

+ &unit.data[0], unit.data.size(), unit.key_id, unit.iv,

unit.subsamples.empty() ? NULL : &unit.subsamples[0],

unit.subsamples.size(),

unit.timestamp);