media/BUILD.gn - Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/BUILD.gn

Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc/peer_connection_dependency_factory.cc ('K') | « content/renderer/media/webrtc/peer_connection_dependency_factory.cc ('k') | media/base/android/BUILD.gn » ('j') | media/base/android/media_codec_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/BUILD.gn

diff --git a/media/BUILD.gn b/media/BUILD.gn

index 4d7e198a9200f2ab6f26cb186f8c635b44482f6e..97b05798510f07001248dd10846604a63ea80f08 100644

--- a/media/BUILD.gn

+++ b/media/BUILD.gn

@@ -395,6 +395,14 @@ component("media") {

"//media/base/android:media_jni_headers",

"//media/base/android:video_capture_jni_headers",

]

+ if (current_cpu == "arm64" || current_cpu == "x64" ||

Tima Vaisburd 2015/12/04 02:04:48 Please explain why we only use NDK for 64 bits her

qinmin 2015/12/04 20:26:04 Done.

+ current_cpu == "mips64el") {

+ sources += [

+ "base/android/ndk_media_codec_bridge.cc",

+ "base/android/ndk_media_codec_bridge.h",

+ ]

+ libs += [ "-lmediandk" ]

+ }

allow_circular_includes_from = [ "//media/base/android" ]

}