media/base/android/media_codec_audio_decoder.cc - Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_audio_decoder.cc

Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add media_codec_util.cc(h) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/base/android/java/src/org/chromium/media/MediaCodecUtil.java ('k') | media/base/android/media_codec_bridge.h » ('j') | media/base/android/media_codec_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_audio_decoder.cc

diff --git a/media/base/android/media_codec_audio_decoder.cc b/media/base/android/media_codec_audio_decoder.cc

index 4b8a0768b82db34e51aeea8654c2585fd55c2da5..0561195df879380ae02ccf11b4b1787b5a8c3522 100644

--- a/media/base/android/media_codec_audio_decoder.cc

+++ b/media/base/android/media_codec_audio_decoder.cc

@@ -6,8 +6,8 @@

#include "base/bind.h"

#include "base/logging.h"

-#include "media/base/android/media_codec_bridge.h"

#include "media/base/android/media_statistics.h"

+#include "media/base/android/sdk_media_codec_bridge.h"

#include "media/base/audio_timestamp_helper.h"

#include "media/base/demuxer_stream.h"

@@ -144,7 +144,7 @@ MediaCodecDecoder::ConfigStatus MediaCodecAudioDecoder::ConfigureInternal(

return kConfigFailure;

if (!(static_cast<AudioCodecBridge*>(media_codec_bridge_.get()))

- ->Start(

+ ->ConfigureAndStart(

configs_.audio_codec,

configs_.audio_sampling_rate,

configs_.audio_channels,