tests/GpuDrawPathTest.cpp - Issue 1472733002: Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/GpuDrawPathTest.cpp

Issue 1472733002: Include conic weights in GrPath cache kSimpleVolatilePathDomain keys (Closed) Base URL: https://skia.googlesource.com/skia.git@commandbuffer-as-api-02-other-tests-refactor

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/GpuDrawPathTest.cpp

diff --git a/tests/GpuDrawPathTest.cpp b/tests/GpuDrawPathTest.cpp

index 42083fe08f2f3788d82688934dd7700d6614c29c..7a6be6d983e91f6f8b2c6123d3eccdc930ec8179 100644

--- a/tests/GpuDrawPathTest.cpp

+++ b/tests/GpuDrawPathTest.cpp

@@ -128,9 +128,7 @@ DEF_TEST(GrPathKeys, reporter) {

GrStrokeInfo stroke(SkStrokeRec::kFill_InitStyle);

GrPath::ComputeKey(path1, stroke, &key1, &isVolatile);

GrPath::ComputeKey(path2, stroke, &key2, &isVolatile);

- // https://bugs.chromium.org/p/skia/issues/detail?id=4580

- // REPORTER_ASSERT(reporter, key1 != key2);

+ REPORTER_ASSERT(reporter, key1 != key2);

}

#endif

« no previous file with comments | « src/gpu/GrPath.cpp ('k') | no next file » | no next file with comments »