Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 14722011: MediaPlayer cleanup, part one of N (Closed)

Created:
7 years, 7 months ago by adamk
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, danakj, feature-media-reviews_chromium.org, Stephen Chennney, jeez, vcarbune.chromium, scherkus (not reviewing)
Visibility:
Public.

Description

MediaPlayer cleanup, part one of N Get rid of a lot of dead code in MediaPlayer and associated classes, and simplify MediaPlayer now that there's only a single MediaEngine to worry about. Note that this is just the beginning: there's clearly lots more to be done, and some the layers here probably no longer need to exist. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -278 lines) Patch
Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 2 chunks +1 line, -12 lines 0 comments Download
Source/core/dom/DOMImplementation.cpp View 2 chunks +3 lines, -20 lines 0 comments Download
Source/core/html/HTMLMediaElement.h View 3 chunks +1 line, -10 lines 0 comments Download
Source/core/html/HTMLMediaElement.cpp View 4 chunks +2 lines, -33 lines 0 comments Download
Source/core/platform/MIMETypeRegistry.h View 1 chunk +0 lines, -3 lines 0 comments Download
Source/core/platform/chromium/MIMETypeRegistryChromium.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
Source/core/platform/graphics/MediaPlayer.h View 7 chunks +3 lines, -30 lines 0 comments Download
Source/core/platform/graphics/MediaPlayer.cpp View 12 chunks +27 lines, -156 lines 0 comments Download
Source/core/platform/graphics/MediaPlayerPrivate.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
adamk
7 years, 7 months ago (2013-05-03 22:27:51 UTC) #1
eseidel
lgtm We should figure out who wants to own the media code. It was sherkus? ...
7 years, 7 months ago (2013-05-04 01:14:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14722011/1
7 years, 7 months ago (2013-05-04 01:15:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6663
7 years, 7 months ago (2013-05-04 03:27:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14722011/1
7 years, 7 months ago (2013-05-05 17:17:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6735
7 years, 7 months ago (2013-05-05 17:47:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14722011/1
7 years, 7 months ago (2013-05-06 18:50:16 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 19:36:23 UTC) #8
Message was sent while issue was closed.
Change committed as 149779

Powered by Google App Engine
This is Rietveld 408576698