src/objects-debug.cc - Issue 14721009: Track computed literal properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove PLACEHOLDER_VALUE Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 891f0d2302daee66039130097592cd9981b56564..1d55e265725143a51a0680873f044c008dc4e862 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -312,8 +312,9 @@ void JSObject::JSObjectVerify() {

Representation r = descriptors->GetDetails(i).representation();

int field = descriptors->GetFieldIndex(i);

Object* value = RawFastPropertyAt(field);

- if (r.IsSmi()) ASSERT(value->IsSmi());

if (r.IsDouble()) ASSERT(value->IsHeapNumber());

+ if (value->IsUninitialized()) continue;

+ if (r.IsSmi()) ASSERT(value->IsSmi());

if (r.IsHeapObject()) ASSERT(value->IsHeapObject());

}

« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »