Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: src/objects-debug.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 891f0d2302daee66039130097592cd9981b56564..f5fcc5039a6ec1d1436adac67f951197df48b151 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -312,6 +312,9 @@ void JSObject::JSObjectVerify() {
Representation r = descriptors->GetDetails(i).representation();
int field = descriptors->GetFieldIndex(i);
Object* value = RawFastPropertyAt(field);
+ // Ignore values set to undefined. Undefined could be the placeholder
+ // for fields that did not yet have a representation.
+ if (value->IsUndefined()) continue;
danno 2013/06/06 07:54:19 Maybe using another sentinel is a better idea for
Toon Verwaest 2013/06/06 10:31:41 The hole value has a special meaning when placed i
if (r.IsSmi()) ASSERT(value->IsSmi());
if (r.IsDouble()) ASSERT(value->IsHeapNumber());
if (r.IsHeapObject()) ASSERT(value->IsHeapObject());

Powered by Google App Engine
This is Rietveld 408576698