Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Side by Side Diff: src/property.h

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove PLACEHOLDER_VALUE Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/parser.cc ('k') | src/property-details.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 Isolate* isolate() const { return isolate_; } 196 Isolate* isolate() const { return isolate_; }
197 197
198 void DescriptorResult(JSObject* holder, PropertyDetails details, int number) { 198 void DescriptorResult(JSObject* holder, PropertyDetails details, int number) {
199 lookup_type_ = DESCRIPTOR_TYPE; 199 lookup_type_ = DESCRIPTOR_TYPE;
200 holder_ = holder; 200 holder_ = holder;
201 details_ = details; 201 details_ = details;
202 number_ = number; 202 number_ = number;
203 } 203 }
204 204
205 bool CanHoldValue(Handle<Object> value) { 205 bool CanHoldValue(Handle<Object> value) {
206 if (IsNormal()) return true;
207 ASSERT(!IsTransition());
206 return value->FitsRepresentation(details_.representation()); 208 return value->FitsRepresentation(details_.representation());
207 } 209 }
208 210
209 void TransitionResult(JSObject* holder, int number) { 211 void TransitionResult(JSObject* holder, int number) {
210 lookup_type_ = TRANSITION_TYPE; 212 lookup_type_ = TRANSITION_TYPE;
211 details_ = PropertyDetails(NONE, TRANSITION, Representation::None()); 213 details_ = PropertyDetails(NONE, TRANSITION, Representation::None());
212 holder_ = holder; 214 holder_ = holder;
213 number_ = number; 215 number_ = number;
214 } 216 }
215 217
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 JSReceiver* holder_; 487 JSReceiver* holder_;
486 int number_; 488 int number_;
487 bool cacheable_; 489 bool cacheable_;
488 PropertyDetails details_; 490 PropertyDetails details_;
489 }; 491 };
490 492
491 493
492 } } // namespace v8::internal 494 } } // namespace v8::internal
493 495
494 #endif // V8_PROPERTY_H_ 496 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/parser.cc ('k') | src/property-details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698