Track computed literal properties.

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 955 matching lines @@
 
 
 
   // We will potentially reorder the property assignments, so they must be
   // simple enough that the ordering does not matter.
   void AssignmentFromParameter(Handle<String> name, int index) {
     EnsureInitialized();
     for (int i = 0; i < names_.length(); ++i) {
       if (name->Equals(*names_[i])) {
         assigned_arguments_[i] = index;
-        assigned_constants_[i] = isolate_->factory()->undefined_value();
+        assigned_constants_[i] = isolate_->factory()->uninitialized_value();
         return;
       }
     }
     names_.Add(name, zone());
     assigned_arguments_.Add(index, zone());
-    assigned_constants_.Add(isolate_->factory()->undefined_value(), zone());
+    assigned_constants_.Add(isolate_->factory()->uninitialized_value(), zone());
   }
 
   void AssignmentFromConstant(Handle<String> name, Handle<Object> value) {
     EnsureInitialized();
     for (int i = 0; i < names_.length(); ++i) {
       if (name->Equals(*names_[i])) {
         assigned_arguments_[i] = -1;
         assigned_constants_[i] = value;
         return;
       }
@@ skipping 2786 matching lines @@
   int depth = 1;
   bool is_holey = false;
   for (int i = 0, n = values->length(); i < n; i++) {
     MaterializedLiteral* m_literal = values->at(i)->AsMaterializedLiteral();
     if (m_literal != NULL && m_literal->depth() + 1 > depth) {
       depth = m_literal->depth() + 1;
     }
     Handle<Object> boilerplate_value = GetBoilerplateValue(values->at(i));
     if (boilerplate_value->IsTheHole()) {
       is_holey = true;
-    } else if (boilerplate_value->IsUndefined()) {
+    } else if (boilerplate_value->IsUninitialized()) {
       is_simple = false;
       JSObject::SetOwnElement(
           array, i, handle(Smi::FromInt(0), isolate()), kNonStrictMode);
     } else {
       JSObject::SetOwnElement(array, i, boilerplate_value, kNonStrictMode);
     }
   }
 
   Handle<FixedArrayBase> element_values(array->elements());
 
@@ skipping 78 matching lines @@
 }
 
 
 Handle<Object> Parser::GetBoilerplateValue(Expression* expression) {
   if (expression->AsLiteral() != NULL) {
     return expression->AsLiteral()->handle();
   }
   if (CompileTimeValue::IsCompileTimeValue(expression)) {
     return CompileTimeValue::GetValue(expression);
   }
-  return isolate()->factory()->undefined_value();
+  return isolate()->factory()->uninitialized_value();
 }
 
 // Validation per 11.1.5 Object Initialiser
 class ObjectLiteralPropertyChecker {
  public:
   ObjectLiteralPropertyChecker(Parser* parser, LanguageMode language_mode) :
     props_(Literal::Match),
     parser_(parser),
     language_mode_(language_mode) {
   }
@@ skipping 90 matching lines @@
     if (m_literal != NULL && m_literal->depth() >= depth_acc) {
       depth_acc = m_literal->depth() + 1;
     }
 
     // Add CONSTANT and COMPUTED properties to boilerplate. Use undefined
     // value for COMPUTED properties, the real value is filled in at
     // runtime. The enumeration order is maintained.
     Handle<Object> key = property->key()->handle();
     Handle<Object> value = GetBoilerplateValue(property->value());
 
-    // Ensure objects with doubles are always treated as nested objects.
+    // Ensure objects that may, at any point in time, contain fields with double
+    // representation are always treated as nested objects. This is true for
+    // computed fields (value is undefined), and smi and double literals
+    // (value->IsNumber()).
     // TODO(verwaest): Remove once we can store them inline.
-    if (FLAG_track_double_fields && value->IsNumber()) {
+    if (FLAG_track_double_fields &&
+        (value->IsNumber() || value->IsUninitialized())) {
       *may_store_doubles = true;
     }
 
-    is_simple_acc = is_simple_acc && !value->IsUndefined();
+    is_simple_acc = is_simple_acc && !value->IsUninitialized();
 
     // Keep track of the number of elements in the object literal and
     // the largest element index.  If the largest element index is
     // much larger than the number of elements, creating an object
     // literal with fast elements will be a waste of space.
     uint32_t element_index = 0;
     if (key->IsString()
         && Handle<String>::cast(key)->AsArrayIndex(&element_index)
         && element_index > max_element_index) {
       max_element_index = element_index;
@@ skipping 2012 matching lines @@
       ASSERT(info()->isolate()->has_pending_exception());
     } else {
       result = ParseProgram();
     }
   }
   info()->SetFunction(result);
   return (result != NULL);
 }
 
 } }  // namespace v8::internal