Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: src/bootstrapper.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove PLACEHOLDER_VALUE Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « include/v8.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1068 matching lines...) Expand 10 before | Expand all | Expand 10 after
1079 function->shared()->set_instance_class_name(*arguments_string); 1079 function->shared()->set_instance_class_name(*arguments_string);
1080 function->shared()->set_expected_nof_properties(2); 1080 function->shared()->set_expected_nof_properties(2);
1081 Handle<JSObject> result = factory->NewJSObject(function); 1081 Handle<JSObject> result = factory->NewJSObject(function);
1082 1082
1083 native_context()->set_arguments_boilerplate(*result); 1083 native_context()->set_arguments_boilerplate(*result);
1084 // Note: length must be added as the first property and 1084 // Note: length must be added as the first property and
1085 // callee must be added as the second property. 1085 // callee must be added as the second property.
1086 CHECK_NOT_EMPTY_HANDLE(isolate, 1086 CHECK_NOT_EMPTY_HANDLE(isolate,
1087 JSObject::SetLocalPropertyIgnoreAttributes( 1087 JSObject::SetLocalPropertyIgnoreAttributes(
1088 result, factory->length_string(), 1088 result, factory->length_string(),
1089 factory->undefined_value(), DONT_ENUM)); 1089 factory->undefined_value(), DONT_ENUM,
1090 Object::FORCE_TAGGED));
1090 CHECK_NOT_EMPTY_HANDLE(isolate, 1091 CHECK_NOT_EMPTY_HANDLE(isolate,
1091 JSObject::SetLocalPropertyIgnoreAttributes( 1092 JSObject::SetLocalPropertyIgnoreAttributes(
1092 result, factory->callee_string(), 1093 result, factory->callee_string(),
1093 factory->undefined_value(), DONT_ENUM)); 1094 factory->undefined_value(), DONT_ENUM,
1095 Object::FORCE_TAGGED));
1094 1096
1095 #ifdef DEBUG 1097 #ifdef DEBUG
1096 LookupResult lookup(isolate); 1098 LookupResult lookup(isolate);
1097 result->LocalLookup(heap->callee_string(), &lookup); 1099 result->LocalLookup(heap->callee_string(), &lookup);
1098 ASSERT(lookup.IsField()); 1100 ASSERT(lookup.IsField());
1099 ASSERT(lookup.GetFieldIndex().field_index() == Heap::kArgumentsCalleeIndex); 1101 ASSERT(lookup.GetFieldIndex().field_index() == Heap::kArgumentsCalleeIndex);
1100 1102
1101 result->LocalLookup(heap->length_string(), &lookup); 1103 result->LocalLookup(heap->length_string(), &lookup);
1102 ASSERT(lookup.IsField()); 1104 ASSERT(lookup.IsField());
1103 ASSERT(lookup.GetFieldIndex().field_index() == Heap::kArgumentsLengthIndex); 1105 ASSERT(lookup.GetFieldIndex().field_index() == Heap::kArgumentsLengthIndex);
(...skipping 1523 matching lines...) Expand 10 before | Expand all | Expand 10 after
2627 return from + sizeof(NestingCounterType); 2629 return from + sizeof(NestingCounterType);
2628 } 2630 }
2629 2631
2630 2632
2631 // Called when the top-level V8 mutex is destroyed. 2633 // Called when the top-level V8 mutex is destroyed.
2632 void Bootstrapper::FreeThreadResources() { 2634 void Bootstrapper::FreeThreadResources() {
2633 ASSERT(!IsActive()); 2635 ASSERT(!IsActive());
2634 } 2636 }
2635 2637
2636 } } // namespace v8::internal 2638 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698