Track computed literal properties.

src/arm/lithium-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2329 matching lines @@
              instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {
     val = UseRegister(instr->value());
   }
 
   // We need a temporary register for write barrier of the map field.
   LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
 
   LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp);
-  if ((FLAG_track_fields && instr->field_representation().IsSmi()) ||
-      (FLAG_track_heap_object_fields &&
-       instr->field_representation().IsHeapObject())) {
-    return AssignEnvironment(result);
+  if (FLAG_track_fields && instr->field_representation().IsSmi()) {
+    if (!instr->value()->range()->IsInSmiRange()) {

[danno, 2013/06/06 07:54:19]

What about also checking !instr->value()->type().IsSmi()? Also, careful with the
SmiRange check. On x64, I don't know if there is a guarantee that we won't get
tagged values in the SmiRange that are boxed, the range is independent of the
representation. 

[Toon Verwaest, 2013/06/06 10:31:41]

This is an obsolete requirement. Nowadays we require the value to come in as a
smi, so it'll always be "InSmiRange()" and smi. Removing.

On 2013/06/06 07:54:19, danno wrote:

+      return AssignEnvironment(result);
+    }
+  } else if (FLAG_track_heap_object_fields &&
+             instr->field_representation().IsHeapObject()) {
+    if (!instr->value()->type().IsHeapObject()) {
+      return AssignEnvironment(result);
+    }
   }
   return result;
 }
 
 
 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
   LOperand* obj = UseFixed(instr->object(), r1);
   LOperand* val = UseFixed(instr->value(), r0);
 
   LInstruction* result = new(zone()) LStoreNamedGeneric(obj, val);
@@ skipping 260 matching lines @@
 
 
 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
   LOperand* object = UseRegister(instr->object());
   LOperand* index = UseRegister(instr->index());
   return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
 }
 
 
 } }  // namespace v8::internal