Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: content/gpu/gpu_main.cc

Issue 147203005: Linux Sandbox: Stop GPU watchdog in accountable way. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use SafeScopedFD properly. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/gpu/gpu_main.cc
diff --git a/content/gpu/gpu_main.cc b/content/gpu/gpu_main.cc
index 713b3373b63f32e98adbf31379695ef6606c16fb..4086e96f6e3763bff4093323a9777e7695db77c0 100644
--- a/content/gpu/gpu_main.cc
+++ b/content/gpu/gpu_main.cc
@@ -422,13 +422,17 @@ bool StartSandboxLinux(const gpu::GPUInfo& gpu_info,
WarmUpSandboxNvidia(gpu_info, should_initialize_gl_context);
- if (watchdog_thread)
- watchdog_thread->Stop();
+ if (watchdog_thread) {
+ // LinuxSandbox needs to be able to ensure that the thread
+ // has really been stopped.
+ LinuxSandbox::StopThread(watchdog_thread);
+ }
// LinuxSandbox::InitializeSandbox() must always be called
// with only one thread.
res = LinuxSandbox::InitializeSandbox();
- if (watchdog_thread)
+ if (watchdog_thread) {
watchdog_thread->Start();
+ }
return res;
}

Powered by Google App Engine
This is Rietveld 408576698