Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 14715019: New policy to enable/disable HTTP-based downloads. (Closed)

Created:
7 years, 7 months ago by Jay Srinivasan
Modified:
7 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

New policy to enable/disable HTTP-based downloads. This is required as a safety net before we rollout HTTP to everyone in the stable-channel. BUG=chromium:235562 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199696

Patch Set 1 #

Patch Set 2 : Provided an explicit default value #

Total comments: 1

Patch Set 3 : Removed extra whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/policy/proto/chromeos/chrome_device_policy.proto View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
binzhao
lgtm
7 years, 7 months ago (2013-05-09 21:52:52 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 7 months ago (2013-05-09 22:05:31 UTC) #2
dgarrett
lgtm https://codereview.chromium.org/14715019/diff/4001/chrome/browser/policy/proto/chromeos/chrome_device_policy.proto File chrome/browser/policy/proto/chromeos/chrome_device_policy.proto (right): https://codereview.chromium.org/14715019/diff/4001/chrome/browser/policy/proto/chromeos/chrome_device_policy.proto#newcode207 chrome/browser/policy/proto/chromeos/chrome_device_policy.proto:207: optional bool http_downloads_enabled = 7 [default = false] ...
7 years, 7 months ago (2013-05-09 22:15:47 UTC) #3
Mattias Nissler (ping if slow)
LGTM
7 years, 7 months ago (2013-05-10 08:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaysri@chromium.org/14715019/15001
7 years, 7 months ago (2013-05-10 19:39:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=147128
7 years, 7 months ago (2013-05-11 04:09:48 UTC) #6
Mattias Nissler (ping if slow)
FWIW, this CL could have mentioned AU in the subject line, it's the second time ...
7 years, 7 months ago (2013-05-13 08:03:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaysri@chromium.org/14715019/15001
7 years, 7 months ago (2013-05-13 08:03:58 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 10:36:43 UTC) #9
Message was sent while issue was closed.
Change committed as 199696

Powered by Google App Engine
This is Rietveld 408576698