Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 14715002: Tweaks to top controls behavior for fullscreen API support. (Closed)

Created:
7 years, 7 months ago by Ted C
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Tweaks to top controls behavior for fullscreen API support. 1.) When at the top of the page, do not apply a reverse scroll to the root layer to prevent the toolbar from overlapping. Allows us to programatically bring in the top controls and have it appear nicely by moving down the content. 2.) Increase animation time slightly to for smoother full height animations. BUG=234649 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cc/input/top_controls_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted C
aelias@ - PTAL
7 years, 7 months ago (2013-04-30 22:24:47 UTC) #1
aelias_OOO_until_Jul13
lgtm
7 years, 7 months ago (2013-05-01 00:21:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/14715002/1
7 years, 7 months ago (2013-05-01 00:41:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=108926
7 years, 7 months ago (2013-05-01 02:28:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/14715002/1
7 years, 7 months ago (2013-05-01 02:34:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=35236
7 years, 7 months ago (2013-05-01 05:39:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/14715002/1
7 years, 7 months ago (2013-05-01 16:26:09 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 16:26:19 UTC) #8
Message was sent while issue was closed.
Change committed as 197634

Powered by Google App Engine
This is Rietveld 408576698