Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1471393003: Dart: Remove unused library and example (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Remove unused library and example This CL removes: - //mojo/common/dart and - //examples/dart/traced_application The tracing library under //mojo/common/dart/ has been replaced by the tracing support added in the dart:developer library. This CL also removes the example using the library. Examples of using the tracing from dart:developer are in: - //benchmarks/dart_startup and - //benchmarks/mojo_rtt_benchmark fixes #546 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/785e11e20e6a77b882b03134e8b705541923ed96

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -440 lines) Patch
M benchmarks/dart_handler_running/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M benchmarks/dart_startup/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M benchmarks/mojo_rtt_benchmark/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/dart/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D examples/dart/traced_application/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D examples/dart/traced_application/lib/main.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D examples/dart/traced_application/pubspec.lock View 1 chunk +0 lines, -3 lines 0 comments Download
D examples/dart/traced_application/pubspec.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/common/dart/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/common/dart/lib/src/trace_provider_impl.dart View 1 chunk +0 lines, -98 lines 0 comments Download
D mojo/common/dart/lib/tracing_helper.dart View 1 chunk +0 lines, -186 lines 0 comments Download
D mojo/common/dart/pubspec.lock View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/common/dart/pubspec.yaml View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
zra
5 years ago (2015-12-03 22:53:34 UTC) #2
jamesr
lgtm
5 years ago (2015-12-03 22:54:22 UTC) #3
jamesr
Please make the patch description better. Say what you're deleting and remove the spurious BUG=
5 years ago (2015-12-03 22:54:37 UTC) #4
zra
On 2015/12/03 22:54:37, jamesr wrote: > Please make the patch description better. Say what you're ...
5 years ago (2015-12-03 23:00:55 UTC) #8
zra
5 years ago (2015-12-03 23:01:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
785e11e20e6a77b882b03134e8b705541923ed96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698