Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6542)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 14711006: Quick fix to get 7DA counts for unified Chrome / App Launcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing mix-up between InstallationState and InstallationLevel. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 295028c86db6fc24a0fcbfb92a555ebf1de049e9..e86a867a5b08263144a847365d5a22ba84d734cc 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -24,6 +24,7 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths_internal.h"
#include "chrome/common/chrome_result_codes.h"
+#include "chrome/installer/launcher_support/chrome_launcher_support.h"
#include "chrome/installer/setup/install.h"
#include "chrome/installer/setup/install_worker.h"
#include "chrome/installer/setup/setup_constants.h"
@@ -1231,6 +1232,26 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
// Notify the shell that associations have changed since Chrome was likely
// unregistered.
SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
+
+ // TODO(huangs): Implement actual migration code and remove the hack below.
+ // Remove the "shadow" App Launcher registry keys.
+ if (installer_state.is_multi_install()) {
+ // If we're not uninstalling the legacy App Launcher, and if it was
+ // not installed in the first place, then delete the "shadow" keys.
+ chrome_launcher_support::InstallationState level_to_check =
+ installer_state.system_install() ?
+ chrome_launcher_support::INSTALLED_AT_SYSTEM_LEVEL :
+ chrome_launcher_support::INSTALLED_AT_USER_LEVEL;
+ bool has_legacy_app_launcher = level_to_check ==
+ chrome_launcher_support::GetAppLauncherInstallationState();
+ if (!has_legacy_app_launcher) {
+ BrowserDistribution* shadow_app_launcher_dist =
+ BrowserDistribution::GetSpecificDistribution(
+ BrowserDistribution::CHROME_APP_HOST);
+ InstallUtil::DeleteRegistryKey(reg_root,
+ shadow_app_launcher_dist->GetVersionKey());
+ }
+ }
}
if (product.is_chrome_frame()) {
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698