Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/dom/CustomElementConstructor.cpp

Issue 14711003: Custom Element constructors should synchronously invoke the ready callback (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/dom/custom/constructor-calls-ready-synchronously-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 32
33 #include "core/dom/CustomElementConstructor.h" 33 #include "core/dom/CustomElementConstructor.h"
34 34
35 #include "core/dom/CustomElementRegistry.h"
35 #include "core/dom/Document.h" 36 #include "core/dom/Document.h"
36 #include "core/dom/Element.h" 37 #include "core/dom/Element.h"
37 38
38 namespace WebCore { 39 namespace WebCore {
39 40
40 PassRefPtr<CustomElementConstructor> CustomElementConstructor::create(Document* document, const QualifiedName& tag, const AtomicString& typeExtension) { 41 PassRefPtr<CustomElementConstructor> CustomElementConstructor::create(Document* document, const QualifiedName& tag, const AtomicString& typeExtension) {
41 return adoptRef(new CustomElementConstructor(document, tag, typeExtension)); 42 return adoptRef(new CustomElementConstructor(document, tag, typeExtension));
42 } 43 }
43 44
44 CustomElementConstructor::CustomElementConstructor(Document* document, const Qua lifiedName& tag, const AtomicString& typeExtension) 45 CustomElementConstructor::CustomElementConstructor(Document* document, const Qua lifiedName& tag, const AtomicString& typeExtension)
45 : ContextDestructionObserver(document) 46 : ContextDestructionObserver(document)
46 , m_tag(tag) 47 , m_tag(tag)
47 , m_typeExtension(typeExtension) 48 , m_typeExtension(typeExtension)
48 { 49 {
49 } 50 }
50 51
51 Document* CustomElementConstructor::document() const { 52 Document* CustomElementConstructor::document() const {
52 return toDocument(m_scriptExecutionContext); 53 return toDocument(m_scriptExecutionContext);
53 } 54 }
54 55
55 PassRefPtr<Element> CustomElementConstructor::createElement(ExceptionCode& ec) { 56 PassRefPtr<Element> CustomElementConstructor::createElement(ExceptionCode& ec) {
56 if (!document()) 57 if (!document())
57 return 0; 58 return 0;
58 return document()->createElementNS(m_tag.namespaceURI(), m_tag.localName(), m_typeExtension, ec); 59 RefPtr<Element> result;
60 {
61 CustomElementRegistry::CallbackDeliveryScope deliveryScope;
62 result = document()->createElementNS(m_tag.namespaceURI(), m_tag.localNa me(), m_typeExtension, ec);
63 }
64 return result.release();
59 } 65 }
60 66
61 } 67 }
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/custom/constructor-calls-ready-synchronously-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698