chrome/browser/profiles/profile_info_cache_unittest.cc - Issue 1471073008: Do not do unnecessary recursive deletes for files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_info_cache_unittest.cc

Issue 1471073008: Do not do unnecessary recursive deletes for files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/profile_info_cache_unittest.cc

diff --git a/chrome/browser/profiles/profile_info_cache_unittest.cc b/chrome/browser/profiles/profile_info_cache_unittest.cc

index cd1f8689d28a7eb71dbbee1568f507b0d1d8781a..eb1aa448418db00259ccd01a5815b71e0d27c887 100644

--- a/chrome/browser/profiles/profile_info_cache_unittest.cc

+++ b/chrome/browser/profiles/profile_info_cache_unittest.cc

@@ -609,7 +609,7 @@ TEST_F(ProfileInfoCacheTest, DownloadHighResAvatarTest) {

// Clean up.

EXPECT_NE(std::string::npos, icon_path.MaybeAsASCII().find(file_name));

EXPECT_TRUE(base::PathExists(icon_path));

- EXPECT_TRUE(base::DeleteFile(icon_path, true));

+ EXPECT_TRUE(base::DeleteFile(icon_path, false));

EXPECT_FALSE(base::PathExists(icon_path));

}