Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14707008: Remove WebKit::GraphicsContextBuilder, which was trivial. (Closed)

Created:
7 years, 7 months ago by jbroman
Modified:
7 years, 7 months ago
Reviewers:
jamesr, eseidel
CC:
blink-reviews, Stephen Chennney, danakj
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove WebKit::GraphicsContextBuilder, which was trivial. Replace all uses with explicit construction of a WebCore::GraphicsContext. BUG=236888 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149726

Patch Set 1 #

Patch Set 2 : Undo whitespace change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -77 lines) Patch
M Source/WebKit/chromium/WebKit.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/PageWidgetDelegate.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/WebFontImpl.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebPopupMenuImpl.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewBenchmarkSupportImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/WebKit/chromium/src/painting/GraphicsContextBuilder.h View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jbroman
7 years, 7 months ago (2013-05-03 22:19:00 UTC) #1
eseidel
lgtm OK. Was this recently added for some purpose? Or just added long ago and ...
7 years, 7 months ago (2013-05-04 01:16:31 UTC) #2
jbroman
On 2013/05/04 01:16:31, Eric Seidel (Google) wrote: > lgtm > > OK. Was this recently ...
7 years, 7 months ago (2013-05-04 02:02:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/14707008/2001
7 years, 7 months ago (2013-05-04 02:05:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6675
7 years, 7 months ago (2013-05-04 03:47:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/14707008/2001
7 years, 7 months ago (2013-05-04 04:12:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6679
7 years, 7 months ago (2013-05-04 04:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/14707008/2001
7 years, 7 months ago (2013-05-06 12:54:15 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 12:54:38 UTC) #9
Message was sent while issue was closed. 
Change committed as 149726

Powered by Google App Engine
This is Rietveld 408576698