SPDY - In CreateStream close the SpdySession if socket is not connected.

SPDY - In CreateStream close the SpdySession if socket is not connected.

Added DCHECK for socket being connected.

Added Net.SpdySession.CreateStreamWithSocketConnected histogram to track
the socket not connected case.

Modified CloseIdleSessions tests to initialize SpdySessionWithScoket.

BUG=232894
R=rch@chromium.org
TEST=net unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197722

[Ryan Hamilton, 2013-05-01 03:30:19]

https://codereview.chromium.org/14707005/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/14707005/diff/1/net/spdy/spdy_session.cc#newc...
net/spdy/spdy_session.cc:555: true);
nit: UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
connection_->socket()->IsConnected());

or some such

[ramant (doing other things), 2013-05-01 04:54:01]

Thanks much Ryan for taking a look at this change. Updated the CloseIdleSessions
tests to initialize the SpdySession's socket. PTAL. thanks.

https://codereview.chromium.org/14707005/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/14707005/diff/1/net/spdy/spdy_session.cc#newc...
net/spdy/spdy_session.cc:555: true);
On 2013/05/01 03:30:19, Ryan Hamilton wrote:
> nit: UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
> connection_->socket()->IsConnected());
> 
> or some such

Done.

[Ryan Hamilton, 2013-05-01 15:29:21]

https://codereview.chromium.org/14707005/diff/15001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/14707005/diff/15001/net/spdy/spdy_session.cc#...
net/spdy/spdy_session.cc:554:
UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
I think I meant this:

if (connection_->socket()) {
  UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
      connection_->socket()->IsConnected());
  if (!connection_->socket()->IsConnected()) {
    CloseSessionOnError(...);
  }

In other words, each time we create a stream, we want to know if the socket is
connected or not and histogram that.

[ramant (doing other things), 2013-05-01 17:53:15]

PTAL.

https://codereview.chromium.org/14707005/diff/15001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/14707005/diff/15001/net/spdy/spdy_session.cc#...
net/spdy/spdy_session.cc:554:
UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
On 2013/05/01 15:29:21, Ryan Hamilton wrote:
> I think I meant this:
> 
> if (connection_->socket()) {
>   UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
>       connection_->socket()->IsConnected());
>   if (!connection_->socket()->IsConnected()) {
>     CloseSessionOnError(...);
>   }
> 
> In other words, each time we create a stream, we want to know if the socket is
> connected or not and histogram that.

Done.

[Ryan Hamilton, 2013-05-01 17:58:19]

lgtm

[commit-bot: I haz the power, 2013-05-01 17:58:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14707005/28001

[commit-bot: I haz the power, 2013-05-01 21:30:21]

Change committed as 197722