Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 14704006: Add option to exclude specific annotated Android instrumentation tests. (Closed)

Created:
7 years, 7 months ago by Siva Chandra
Modified:
7 years, 7 months ago
Reviewers:
craigdh, nyquist
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, Isaac (away)
Visibility:
Public.

Description

Add option to exclude specific annotated Android instrumentation tests. BUG=169875 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199170

Patch Set 1 #

Patch Set 2 : Fix a syntac error #

Patch Set 3 : Fix a syntax error #

Total comments: 2

Patch Set 4 : Fix a nit and a typo #

Patch Set 5 : Fix another typo #

Patch Set 6 : Yet another typo fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M build/android/pylib/host_driven/run_python_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/host_driven/test_info_collection.py View 1 2 3 4 5 3 chunks +10 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/dispatch.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 2 chunks +8 lines, -3 lines 0 comments Download
M build/android/pylib/utils/test_options_parser.py View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siva Chandra
The marked bug requires that we exclude tests annotated with 'FeatureSync' from the instrumentation bots. ...
7 years, 7 months ago (2013-05-03 20:23:20 UTC) #1
Isaac (away)
+craigdh ilevy -> cc Please remember to check for OWNERS files.
7 years, 7 months ago (2013-05-04 02:21:50 UTC) #2
craigdh
lgtm with a fix and a nit. https://chromiumcodereview.appspot.com/14704006/diff/9001/build/android/pylib/utils/test_options_parser.py File build/android/pylib/utils/test_options_parser.py (right): https://chromiumcodereview.appspot.com/14704006/diff/9001/build/android/pylib/utils/test_options_parser.py#newcode149 build/android/pylib/utils/test_options_parser.py:149: help=('Comma-separated list ...
7 years, 7 months ago (2013-05-06 16:19:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/14704006/16002
7 years, 7 months ago (2013-05-08 23:01:14 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 09:19:45 UTC) #5
Message was sent while issue was closed.
Change committed as 199170

Powered by Google App Engine
This is Rietveld 408576698