Fix a memory leak in SECITEM_FreeArray.

nss/lib/util/secitem.c

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /*
  * Support routines for SECItem data structure.
  *
  * $Id$
  */
 
@@ skipping 342 matching lines @@
             PORT_Free(result);
         }
         /*
          * If array is not NULL, the above has set array->data and
          * array->len to 0.
          */
     }
     return(NULL);
 }
 
-void secitem_FreeArray(SECItemArray *array, PRBool zero_items, PRBool freeit)
+static void
+secitem_FreeArray(SECItemArray *array, PRBool zero_items, PRBool freeit)
 {
     unsigned int i;
 
     if (!array || !array->len || !array->items)
         return;
 
     for (i=0; i<array->len; ++i) {
         SECItem *item = &array->items[i];
 
         if (item->data) {
             if (zero_items) {
                 SECITEM_ZfreeItem(item, PR_FALSE);
             } else {
                 SECITEM_FreeItem(item, PR_FALSE);
             }
         }
     }
+    PORT_Free(array->items);
+    array->items = NULL;
+    array->len = 0;
 
     if (freeit)
         PORT_Free(array);
 }
 
 void SECITEM_FreeArray(SECItemArray *array, PRBool freeit)
 {
     secitem_FreeArray(array, PR_FALSE, freeit);
 }
 
@@ skipping 19 matching lines @@
         SECStatus rv = SECITEM_CopyItem(arena,
                                         &result->items[i], &from->items[i]);
         if (rv != SECSuccess) {
             SECITEM_ZfreeArray(result, PR_TRUE);
             return NULL;
         }
     }
 
     return result;
 }