Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 14703004: Reland "Unifies ScrollView and RenderLayer to use non-shi..." (Closed)

Created:
7 years, 7 months ago by trchen
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, leviw+renderwatch, danakj, Rik, jchaffraix+rendering, Stephen Chennney, jeez, pdr., Zhenyao Mo
Visibility:
Public.

Description

Reland "Unifies ScrollView and RenderLayer to use non-shi..." This patch needs to be landed at the same time as https://chromiumcodereview.appspot.com/15006004/ Needs to update AutomationRendererHelperTest for some of the RTL tests to work. > Unifies ScrollView and RenderLayer to use non-shifted [minPos, maxPos] scroll offset > > For pages with negative overflow (due to RTL or writing mode), there are > two sets of scroll offset defined. One that ranges from [0, maxPos - minPos] > and the other one ranges from [minPos, maxPos]. To reduce confusion, this > patch unifies ScrollView and RenderLayer to use the second definition of > scroll offset. > > BUG=232063 > TEST=manual > R=jamesr@chromium.org,jchaffraix@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14807003 TBR=jamesr@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150153

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -84 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/overflow/composited-scrolling-paint-phases-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/overflow/scrolling-without-painting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/overflow/textarea-scroll-touch-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/shrink-to-column-height-for-pagination.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-linux/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/platform/ScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollView.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M Source/core/platform/ScrollableArea.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/platform/Scrollbar.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/platform/graphics/chromium/GraphicsLayerChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mac/ScrollAnimatorMac.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 5 chunks +12 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 1 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 7 months ago (2013-05-10 23:41:09 UTC) #1
trchen
7 years, 7 months ago (2013-05-10 23:50:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r150153 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698