media: Generalize MediaPermissionDispatcher.

media: Generalize MediaPermissionDispatcher.

Remove render_frame() reference to make MediaPermissionDispatcher more generic.
This enables us to use MediaPermissionDispatcher in other places.

BUG=559839
Committed: https://crrev.com/6bca21e40d0273798d751b41e0abe9a03928ee3d
Cr-Commit-Position: refs/heads/master@{#373962}

[xhwang, 2015-11-24 08:28:04]

xhwang@chromium.org changed reviewers:
+ nasko@chromium.org

[xhwang, 2015-11-24 08:28:05]

PTAL

https://chromiumcodereview.appspot.com/1470233002/diff/1/content/renderer/ren...
File content/renderer/render_frame_impl.h (right):

https://chromiumcodereview.appspot.com/1470233002/diff/1/content/renderer/ren...
content/renderer/render_frame_impl.h:1003: scoped_ptr<MediaPermissionDispatcher>
media_permission_dispatcher_;
We don't care about any Frame events. So using a scoped_ptr makes more sense. Do
I miss anything?

FWIW, I also want to use MediaPermissionDispatch in the GPU process where a
RenderFrameObserver doesn't make sense.

[nasko, 2015-11-25 15:04:27]

LGTM

https://codereview.chromium.org/1470233002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1470233002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5268: base::Unretained(this))));
Please add a comment why using base::Unretained(this) is safe.

https://codereview.chromium.org/1470233002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/1470233002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.h:1003: scoped_ptr<MediaPermissionDispatcher>
media_permission_dispatcher_;
On 2015/11/24 08:28:05, xhwang wrote:
> We don't care about any Frame events. So using a scoped_ptr makes more sense.
Do
> I miss anything?
> 
> FWIW, I also want to use MediaPermissionDispatch in the GPU process where a
> RenderFrameObserver doesn't make sense.

Makes sense to me. I now wonder why it was an observer to begin with :).

[xhwang, 2016-02-05 22:06:03]

rebase only

[xhwang, 2016-02-05 23:03:55]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-02-05 23:03:56]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1470233002/#ps20001
(title: "rebase only")

[commit-bot: I haz the power, 2016-02-05 23:07:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470233002/20001

[commit-bot: I haz the power, 2016-02-06 00:21:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-06 00:23:10]

Description was changed from

==========
media: Generalize MediaPermissionDispatcher.

Remove render_frame() reference to make MediaPermissionDispatcher more generic.
This enables us to use MediaPermissionDispatcher in other places.

BUG=559839
==========

to

==========
media: Generalize MediaPermissionDispatcher.

Remove render_frame() reference to make MediaPermissionDispatcher more generic.
This enables us to use MediaPermissionDispatcher in other places.

BUG=559839

Committed: https://crrev.com/6bca21e40d0273798d751b41e0abe9a03928ee3d
Cr-Commit-Position: refs/heads/master@{#373962}
==========

[commit-bot: I haz the power, 2016-02-06 00:23:10]

Patchset 2 (id:??) landed as
https://crrev.com/6bca21e40d0273798d751b41e0abe9a03928ee3d
Cr-Commit-Position: refs/heads/master@{#373962}