Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 14701012: Refactor m_absoluteTransform out of SVGFilter and into base class. (Closed)

Created:
7 years, 5 months ago by Stephen White
Modified:
7 years, 4 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, jamesr, danakj, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, jeez
Visibility:
Public.

Description

Refactor m_absoluteTransform out of SVGFilter and into base class. BUG=237213 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149536

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix copyrights #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M Source/core/platform/graphics/filters/Filter.h View 1 4 chunks +6 lines, -2 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 4 chunks +5 lines, -9 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
Stephen: PTAL. Thanks!
7 years, 5 months ago (2013-05-01 18:26:53 UTC) #1
Stephen Chennney
LGTM. It would be nice if you have the time to add Google copyright lines, ...
7 years, 5 months ago (2013-05-01 18:34:17 UTC) #2
Stephen White
On 2013/05/01 18:34:17, Stephen Chenney wrote: > LGTM. > > It would be nice if ...
7 years, 5 months ago (2013-05-01 18:40:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/14701012/5001
7 years, 5 months ago (2013-05-01 18:42:50 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-05-01 20:19:30 UTC) #5
Message was sent while issue was closed.
Change committed as 149536

Powered by Google App Engine
This is Rietveld 408576698