Issue 14698032: Make InputMethodWin TSF-aware.

Issue 14698032: Make InputMethodWin TSF-aware. (Closed)

Created:
7 years, 7 months ago by Yohei Yukawa

Modified:
7 years, 7 months ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make InputMethodWin TSF-aware. This patch set introduces following event handlings so that InputMethodWin can work with TSF-based IME. - Focus handling (OnFocus/OnBlur) - TextInputType handling (OnTextInputTypeChanged) - Composition Handling (OnDidChangeFocus/ConfirmCompositionText) Basically this is just a quick fix and InputMethodWin should be refactored eventually. BUG=239690 TEST=Manually done on Windows 7 with --enable-text-services-framework Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201479

Patch Set 1 : #

Patch Set 2 : Make sure the existing compositon (if any) is terminated #

Patch Set 3 : Implement OnTextLayoutChanged in MockTSFBridge. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -50 lines)			Patch
M	ui/base/ime/win/mock_tsf_bridge.h	View	1 2	3 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/base/ime/win/mock_tsf_bridge.cc	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/base/ime/win/tsf_bridge.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/base/ime/win/tsf_bridge.cc	View		5 chunks	+28 lines, -14 lines	0 comments	Download
M	ui/views/ime/input_method_win.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/ime/input_method_win.cc	View	1	7 chunks	+96 lines, -32 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

lgtm lgtm, but please land after https://codereview.chromium.org/15296005 Thank you.

7 years, 7 months ago (2013-05-20 03:21:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14698032/6002

7 years, 7 months ago (2013-05-21 08:40:27 UTC) #2

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 7 months ago (2013-05-21 10:06:29 UTC) #3

Yohei Yukawa

Hi Nonaka-san, I added mock_tsf_bridge.h/mock_tsf_bridge.cc to fix compile error. Could you take another look?

7 years, 7 months ago (2013-05-21 10:43:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14698032/30001

7 years, 7 months ago (2013-05-22 02:52:21 UTC) #6

Message was sent while issue was closed.

Change committed as 201479

Expand Messages | Collapse Messages